[EFv2] cleanup error and warnings #6704
Conversation
joheredi
requested review from
timotheeguerin,
timovv,
qiaozha,
MaryGao,
xirzec,
bterlson,
markcowl,
allenjzhang,
witemple-msft,
chrisradek and
AlitzelMendez
as code owners
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
joheredi
force-pushed
the
internal/js-cleanup-errors
branch
from
18072df to
519256f
Compare
joheredi
force-pushed
the
internal/js-cleanup-errors
branch
from
519256f to
e8d97f6
Compare
joheredi
force-pushed
the
internal/js-cleanup-errors
branch
from
e8d97f6 to
e406e41
Compare
joheredi
force-pushed
the
internal/js-cleanup-errors
branch
from
e406e41 to
97e8497
Compare
| @@ -43,7 +44,12 @@ defineKit<TypekitExtension>({ | |||
| }, | |||
| getElementType(type) { | |||
| if (!this.record.is(type)) { | |||
| throw new Error("Type is not a record."); | |||
| reportTypekitDiagnostic(this.program, { | |||
There was a problem hiding this comment.
reporting diagnostic from a getter is a bad pattern, it carries the error to the user potentially multiple times without expoissting that to the library author.
Any getter that report diagnmostic should return the error tuple
There was a problem hiding this comment.
in general the same applies to probably all typekits
There was a problem hiding this comment.
i think it might make more sense to also throw if invalid inputs are used, this means that the library author made an error calling this intead of pushing that onto the user
Addressing #6575 making sure there are no unnecessary throws and clean up the diagnostics in Typekit, Efv2 and http-client-js