Skip to content

Fix nested options #6711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 28, 2025
Merged

Fix nested options #6711

merged 20 commits into from
Mar 28, 2025

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Mar 26, 2025 •
edited
Loading

fix #6674

Also fix a crash when passing option without = and stopped showing the yargs help on crash

@microsoft-github-policy-service microsoft-github-policy-service bot added the compiler:core Issues for @typespec/compiler label Mar 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
  • ✅ @typespec/http-client-js
  • ✅ @typespec/http-server-csharp
  • ✅ @typespec/http-server-js
  • ✅ @typespec/http-specs
Show changes

@typespec/compiler - fix ✏️

Fix extra properties not validated in nested entries of the config

@typespec/compiler - fix ✏️

Fix passing nested emitter options with --option

@typespec/http-client-js - internal ✏️

Fix nested options

@typespec/http-server-js - internal ✏️

Fix nested options

@typespec/http-server-csharp - internal ✏️

Fix nested options

@typespec/http-specs - internal ✏️

Fix nested options

@timotheeguerin timotheeguerin marked this pull request as ready for review March 26, 2025 22:26
@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 26, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin timotheeguerin mentioned this pull request Mar 27, 2025
Closed
@markcowl markcowl added this pull request to the merge queue Mar 28, 2025
Merged via the queue into microsoft:main with commit 8346751 Mar 28, 2025
22 checks passed
mario-guerra pushed a commit that referenced this pull request Apr 2, 2025
@timotheeguerin @mario-guerra
Fix nested options (#6711)
041cc0a 
fix #6674

Also fix a crash when passing option without `=` and stopped showing the
yargs help on crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisradek chrisradek chrisradek approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@timovv timovv Awaiting requested review from timovv timovv is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

Assignees

@chrisradek chrisradek

Labels
compiler:core Issues for @typespec/compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli could not set object option
4 participants
@timotheeguerin @azure-sdk @chrisradek @markcowl