Skip to content

Fix playground crash on no target #6753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2025
Merged

Fix playground crash on no target #6753

merged 2 commits into from
Mar 28, 2025

Conversation

timotheeguerin
Copy link
Member

fix #6752

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/playground
Show changes

@typespec/playground - fix ✏️

Guard against diagnostic reported without a target

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin timotheeguerin added this pull request to the merge queue Mar 28, 2025
Merged via the queue into microsoft:main with commit 2d89d3f Mar 28, 2025
22 checks passed
@timotheeguerin timotheeguerin deleted the fix/playground-crash-no-target branch March 28, 2025 18:20
mario-guerra pushed a commit that referenced this pull request Apr 2, 2025
@timotheeguerin @mario-guerra
Fix playground crash on no target (#6753)
773e9e3 
fix #6752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisradek chrisradek chrisradek approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

Assignees
No one assigned
Labels
ui:playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Playground goes blank when choosing TCGC output
3 participants
@timotheeguerin @azure-sdk @chrisradek