Add test case for Typespec Extension - 2 #7969
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-zhocai
requested review from
RodgeFu,
lirenhe,
bterlson,
markcowl,
timotheeguerin,
chrisradek,
AlitzelMendez and
witemple-msft
as code owners
|
All changed packages have been documented.
|
|
I don’t think there is a point to test more than one case for each flow. This is just supposed to check the ui still works anything more specific should be left to faster unit tests |
| "@types/cross-spawn": "~6.0.6", | ||
| "@types/mocha": "^10.0.9", | ||
| "@types/node": "~24.0.3", | ||
| "@types/semver": "^7.5.8", | ||
| "@types/vscode": "~1.100.0", | ||
| "@types/which": "^3.0.4", | ||
| "@typespec/compiler": "workspace:^", | ||
| "@typespec/http": "workspace:^", | ||
| "@typespec/openapi": "workspace:^", | ||
| "@typespec/openapi3": "workspace:^", |
There was a problem hiding this comment.
We also shouldn't have tests that depends on other things. This should be testing the ui in the most basic way not the compile or other functionality of those packages.
| "@types/cross-spawn": "~6.0.6", | ||
| "@types/mocha": "^10.0.9", | ||
| "@types/node": "~24.0.3", | ||
| "@types/semver": "^7.5.8", | ||
| "@types/vscode": "~1.100.0", | ||
| "@types/which": "^3.0.4", | ||
| "@typespec/compiler": "workspace:^", | ||
| "@typespec/http": "workspace:^", | ||
| "@typespec/openapi": "workspace:^", | ||
| "@typespec/openapi3": "workspace:^", |
There was a problem hiding this comment.
We also shouldn't have tests that depends on other things. This should be testing the ui in the most basic way not the compile or other functionality of those packages.
|
Closed this PR, the replacement PR is: #7976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6 cases in
Create TypeSpec Projectincludes:TypeSpec Library (With TypeScript)TypeSpec Emitter (With TypeScript)(rest-api-spec repo) Azure Data Plane Service Project(rest-api-spec repo) Azure Resource Manager Service Project(stand alone) Azure Data Plane Service Project(stand alone) Azure Resource Manager Service Project8 cases in
Emit TypeSpec Projectincludes:Emit Client Code from TypeSpec - PythonEmit Client Code from TypeSpec - JavaEmit Client Code from TypeSpec - .NETEmit Client Code from TypeSpec - JavaScriptEmit OpenAPI 3.x from TypeSpec- triggered by command paletteEmit OpenAPI 3.x from TypeSpec- triggered by right clickEmit Server Stub from TypeSpec - .NETEmit Server Stub from TypeSpec - JavaScript3 cases in
Import TypeSpec from OpenApI3includes:Import TypeSpec from OpenAPI3triggered by command paletteImport TypeSpec from OpenAPI3triggered by right click on fileImport TypeSpec from OpenAPI3triggered by right click on folder2 cases in
Preview API Documentationincludes:Preview API Documentationtriggered by command palettePreview API Documentationtriggered by right click on fileTest case
Emit Server Stub from TypeSpec - JavaScriptcannot be activated temporarily due to a known issue, otherwise it will constantly return errors. For details, please refer to #5580 (comment)