Update CreateMessage call to use new overload with Uri, method, and classifier #8169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the TypeSpec C# HTTP client generator to use the new
CreateMessage
overload introduced in System.ClientModel 1.6.0 that accepts Uri, HTTP method, and response classifier parameters.Changes Made
System.ClientModel Version Update:
NewProjectScaffolding.cs
Generator Code Updates:
ClientPipelineApi.CreateMessage
abstract signature to acceptValueExpression uri
,ValueExpression method
, andValueExpression responseClassifier
parametersClientPipelineProvider.CreateMessage
implementation to pass these parameters to the underlyingClientPipeline.CreateMessage
callRestClientProvider
to build the URI first, then callCreateMessage
with the complete URI and HTTP methodCode Generation Pattern Change:
The generated client code pattern has been updated:
Before:
After:
Test Updates:
This change enables the generator to take advantage of the more efficient
CreateMessage
overload while maintaining full compatibility with existing functionality including complex scenarios like pagination and parameter handling.Fixes #8168.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
telemetry.astro.build
node /home/REDACTED/work/typespec/typespec/website/node_modules/.bin/../astro/astro.js build
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.