Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[godot-cpp] Create a new port #37931

Merged
merged 1 commit into from
Jun 8, 2024
Merged

[godot-cpp] Create a new port #37931

merged 1 commit into from
Jun 8, 2024

Conversation

ytnuf
Copy link
Contributor

@ytnuf ytnuf commented Apr 2, 2024

Fixes #34492

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Notes:

@ytnuf
Copy link
Contributor Author

ytnuf commented Apr 2, 2024

@microsoft-github-policy-service agree

ports/godot-cpp/portfile.cmake Outdated Show resolved Hide resolved
ports/godot-cpp/portfile.cmake Outdated Show resolved Hide resolved
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 3, 2024
@Cheney-W
Copy link
Contributor

Cheney-W commented Apr 3, 2024

godot-cpp:x64-windows-static install failed with below error:

CMake Error at F:/v/vcpkg-37931/downloads/tools/cmake-3.29.0-windows/cmake-3.29.0-windows-i386/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Python3 (missing: Python3_EXECUTABLE Interpreter) (Required
  is at least version "3.4")

@ytnuf
Copy link
Contributor Author

ytnuf commented Apr 5, 2024

godot-cpp:x64-windows-static install failed with below error:

CMake Error at F:/v/vcpkg-37931/downloads/tools/cmake-3.29.0-windows/cmake-3.29.0-windows-i386/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Python3 (missing: Python3_EXECUTABLE Interpreter) (Required
  is at least version "3.4")

@Cheney-W

I'm not entirely sure how to go about this since the python package provided by vcpkg is now broken due to it's dependency on liblzma.

@ytnuf
Copy link
Contributor Author

ytnuf commented Apr 6, 2024

I think using vcpkg_find_acquire_program("PYTHON3") instead might be the solution to my conundrum.

@Cheney-W
Copy link
Contributor

Cheney-W commented Apr 7, 2024

Since the upstream does not provide exports, please use the unofficial-godot-cpp as the export file name and use unofficial::godot:cpp as the export target name in the exports you added.

@ytnuf ytnuf force-pushed the godot-cpp branch 3 times, most recently from d1b29c5 to 8280c29 Compare April 7, 2024 18:11
@ytnuf ytnuf marked this pull request as ready for review April 12, 2024 20:57
@ytnuf ytnuf marked this pull request as draft April 12, 2024 22:05
@luncliff
Copy link
Contributor

Port Requested in #34492 ?

@Cheney-W Cheney-W modified the milestone: https://github.com/microsoft/vcpkg/issues/34492 Apr 16, 2024
Cheney-W
Cheney-W previously approved these changes Apr 17, 2024
@Cheney-W
Copy link
Contributor

Usage test passed with x64-windows-static triplet.

@ytnuf ytnuf marked this pull request as ready for review April 23, 2024 17:39
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Apr 24, 2024
Copy link
Contributor

@JavierMatosD JavierMatosD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll place the PR in draft. Please mark "ready for review" once you've responded so I know.

ports/godot-cpp/vcpkg.json Outdated Show resolved Hide resolved
ports/godot-cpp/usage Outdated Show resolved Hide resolved
ports/godot-cpp/portfile.cmake Outdated Show resolved Hide resolved
ports/godot-cpp/usage Outdated Show resolved Hide resolved
ports/godot-cpp/portfile.cmake Outdated Show resolved Hide resolved
ports/godot-cpp/usage Outdated Show resolved Hide resolved
@Cheney-W Cheney-W removed the info:reviewed Pull Request changes follow basic guidelines label Apr 29, 2024
@ytnuf ytnuf marked this pull request as ready for review May 3, 2024 16:09
Cheney-W
Cheney-W previously approved these changes May 6, 2024
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 6, 2024
@data-queue data-queue marked this pull request as draft May 6, 2024 22:24
@data-queue data-queue removed the info:reviewed Pull Request changes follow basic guidelines label May 13, 2024
@ytnuf ytnuf marked this pull request as ready for review May 27, 2024 11:55
@ytnuf ytnuf requested a review from Cheney-W May 27, 2024 11:56
@Cheney-W
Copy link
Contributor

Upstream has released the latest version 4.2.2: https://github.com/godotengine/godot-cpp/releases/tag/godot-4.2.2-stable, could you please use the latest version? Thank you!

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 4, 2024
@vicroms vicroms merged commit a68a14e into microsoft:master Jun 8, 2024
17 checks passed
@ytnuf ytnuf deleted the godot-cpp branch August 5, 2024 10:07
@LilyWangLL LilyWangLL mentioned this pull request Sep 30, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] godot-cpp
7 participants