-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vst3sdk] New port for Steinberg Virtual Studio Technology 3 SDK #41903
base: master
Are you sure you want to change the base?
Conversation
ae9685b
to
c01a4d8
Compare
791c2b7
to
6b9eda3
Compare
The optional GUI module https://github.com/steinbergmedia/vstgui is not added to this port, as it has own version numbering and release cycle. I was not able to get the macOS builds working on CI and therefore disabled them. It seems that the projects CMake files require the GUI version of Xcode and do not work with the command line version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding osx:
- Not
supported
seems wrong, it is more a CI problem, i.e. afail
in the CI baseline. - Did you try to set
ENV{XCODE_VERSION}
andENV{SDKROOT}
?
(IDK why this project wants environment variables at this point.)
https://github.com/steinbergmedia/vst3_cmake/blob/2022b265cdbcd90b37294d3fb397f9766dbe4c06/modules/SMTG_DetectPlatform.cmake#L48-L60
I already tried to set ENV{XCODE_VERSION}, but this alone was not sufficient. |
Taking another look, that cmake script doesn't look convincing at all. The key question is if they really need the XCode generator or GUI at some point, or if they just didn't know how to to make their cmake build more flexible. |
…s failing in CI baseline
b971892
to
491b2fe
Compare
Removed accidental added version entry "3.7.12" from vst3sdk.json.
ports/vst3sdk/portfile.cmake
Outdated
# Suppress CRT linkage check | ||
set(VCPKG_POLICY_SKIP_CRT_LINKAGE_CHECK enabled) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it okay to suppress this check?
(Why doesn't it use vcpkg_check_linkage()
?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not get it to work with vcpkg_check_linkage
so I removed these triplets from the list of supported triplets by !staticcrt
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
3fc449d
to
d506c28
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format if/else like
if(...)
if(...)
a()
else()
b()
endif()
endif()
Use executables from release build, to support release-only community triplets Fixed if/else/endif indention
@JoergAtGithub, could you please reply @dg0yt's review? |
…plets from suported list
0d7ed1e
to
0dfecb7
Compare
Tested features [
|
if (VCPKG_TARGET_IS_LINUX) | ||
file(INSTALL "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bin/Release/moduleinfotool" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}") | ||
file(INSTALL "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bin/Release/validator" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}") | ||
else() | ||
file(INSTALL "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bin/moduleinfotool${VCPKG_TARGET_EXECUTABLE_SUFFIX}" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}") | ||
file(INSTALL "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/bin/validator${VCPKG_TARGET_EXECUTABLE_SUFFIX}" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}") | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these executables required for the proper function of the library? Executable files should be installed in tools\${PORT}
rather than share\${PORT}
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.