Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libpng] Update to 1.6.44, add feature tools #42058

Merged
merged 7 commits into from
Nov 14, 2024
Merged

[libpng] Update to 1.6.44, add feature tools #42058

merged 7 commits into from
Nov 14, 2024
+65 −29

Conversation

Osyotr
Copy link
Contributor

@Osyotr Osyotr commented Nov 8, 2024

pnggroup/libpng@v1.6.43...v1.6.44

Note: libpng now installs PNGConfig.cmake. CMake wrapper is removed. libpng-config.cmake is kept for backwards compatibility.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 8, 2024

Could libpng-config.cmake be replaced with a forwarding+warning script like ports/xmlsec/xmlsec-config.cmake?

dg0yt
dg0yt reviewed Nov 8, 2024
View reviewed changes
ports/libpng/vcpkg.json Outdated Show resolved Hide resolved
ports/libpng/vcpkg.json Outdated Show resolved Hide resolved
dg0yt
dg0yt reviewed Nov 8, 2024
View reviewed changes
ports/libpng/portfile.cmake Outdated Show resolved Hide resolved
Osyotr and others added 2 commits November 9, 2024 00:15
@Osyotr @dg0yt
Fix config dir
1202260 
Co-authored-by: Kai Pastor <[email protected]>
@Osyotr
v db
669e488
@Osyotr Osyotr marked this pull request as ready for review November 9, 2024 15:58
@WangWeiLin-MV WangWeiLin-MV self-assigned this Nov 11, 2024
WangWeiLin-MV
WangWeiLin-MV reviewed Nov 11, 2024
View reviewed changes
ports/libpng/libpng-config.cmake Outdated Show resolved Hide resolved
ports/libpng/usage Show resolved Hide resolved
@WangWeiLin-MV WangWeiLin-MV added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision labels Nov 11, 2024
WangWeiLin-MV
WangWeiLin-MV previously approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port features usage tests pass with the following triplets:

  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Nov 12, 2024
vicroms
vicroms requested changes Nov 12, 2024
View reviewed changes
ports/libpng/vcpkg.json Outdated Show resolved Hide resolved
@Osyotr Osyotr requested a review from vicroms November 12, 2024 14:36
@vicroms vicroms merged commit a469702 into microsoft:master Nov 14, 2024
16 checks passed
@Osyotr Osyotr deleted the libpng-tools branch November 14, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@vicroms vicroms vicroms approved these changes

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV left review comments

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Osyotr @dg0yt @vicroms @WangWeiLin-MV