-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tomsolver] Add new port #42096
[tomsolver] Add new port #42096
Conversation
ports/tomsolver/usage
Outdated
The package tomsolver provides CMake targets: | ||
|
||
find_package(tomsolver CONFIG REQUIRED) | ||
target_link_libraries(main PRIVATE tomsolver::tomsolver) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new line at the end of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have modified it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this information at this page:
Merging is blocked
Merging can be performed automatically once the requested changes are addressed.
I have added the new line at those two files, but this PR has not been merged automatically.
What should I do next?
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging is not automatic. There official reviewer, and there people who merge what was flagged as reviewed.
9392760
to
65c2de4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the heuristical usage output is good enough, an explicit usage file is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry.
Sorry I am a newer and not know well with vcpkg's cmake machinism. I just follow this tutorial, so I don't know how to implement the "heuristical usage output". |
If a port doesn't have a usage file, |
I learnt it and removed the usage file. |
@tomwillow Usage test failed on |
I'm a bit confused because on this page, there is a message stating:
Additionally, I have tested on my local machine (Windows 10 x64) with the following steps:
Could you give me more details? Thanks. |
Create a CMake project, add usage to The reason for not being able to find the header file is that your CMakeList file is missing |
Co-authored-by: Kai Pastor <[email protected]>
@Mengna-Li Sorry for my mistake. I had previously tested on my machine, but my environment was not entirely clean. |
Usage tested pass on x64-windws. |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.