Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] Update to 6.8.2 #43660

Merged
merged 6 commits into from
Feb 8, 2025
Merged

[Qt] Update to 6.8.2 #43660

merged 6 commits into from
Feb 8, 2025

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Feb 6, 2025

closes #43621

@nirvn nirvn mentioned this pull request Feb 7, 2025
@WangWeiLin-MV WangWeiLin-MV added the category:port-update The issue is with a library, which is requesting update new revision label Feb 7, 2025
@Neumann-A Neumann-A marked this pull request as ready for review February 7, 2025 09:19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are speaking about
- #include <litehtml/types.h>
If that include would be needed the code wouldn't compile. The correct include would be
#include <../litehtml/types.h> due to the way the target for litehtml works. using #include <types.h> would be way too general. However, #include <litehtml.h> already used in the file works just as well to get the required types.

@BillyONeal BillyONeal merged commit 1aeec7b into microsoft:master Feb 8, 2025
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the update!

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Feb 8, 2025
autoantwort pushed a commit to autoantwort/vcpkg that referenced this pull request Feb 8, 2025
@Neumann-A Neumann-A deleted the qt_6.8.2 branch February 8, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[qt] Update Qt6 to last stable 6.8.2
3 participants