Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: Ignore .default if it is passed as a scope #1540

Merged
merged 1 commit into from
Jul 21, 2023
Merged

auth: Ignore .default if it is passed as a scope #1540

merged 1 commit into from
Jul 21, 2023

Conversation

bwateratmsft
Copy link
Contributor

Fixes #1538

@bwateratmsft bwateratmsft requested a review from a team as a code owner July 21, 2023 12:57
nturinski
nturinski approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any concerns about other scopes not being formatted properly? Or is it only .default where it screws up?

@bwateratmsft
Copy link
Contributor Author

Are there any concerns about other scopes not being formatted properly? Or is it only .default where it screws up?

We'll find out when we find out. 😄

@bwateratmsft bwateratmsft merged commit 343d359 into main Jul 21, 2023
4 checks passed
@bwateratmsft bwateratmsft deleted the bmw/dotdefault branch July 21, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nturinski nturinski nturinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bwateratmsft @nturinski