serviceconnector: Add CosmosDB and Key Vault support #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
reviewed
Jul 26, 2023
| case TargetServiceTypeName.KeyVault: | ||
| return nonNullValue(context.keyVaultAccount?.id); | ||
| default: | ||
| throw new Error('No target type found'); |
There was a problem hiding this comment.
Should this error message be localized?
nturinski
reviewed
Jul 28, 2023
|
|
||
| export class CosmosDBAccountListStep extends AzureWizardPromptStep<ICreateLinkerContext>{ | ||
| public async prompt(context: ICreateLinkerContext): Promise<void> { | ||
| const placeHolder: string = vscode.l10n.t('Select a Database Account'); |
There was a problem hiding this comment.
nit: Unless it's prefixed with "Azure", we shouldn't capitalize resource types.
|
|
||
| export class KeyVaultListStep extends AzureWizardPromptStep<ICreateLinkerContext> { | ||
| public async prompt(context: ICreateLinkerContext): Promise<void> { | ||
| const placeHolder: string = vscode.l10n.t('Select a Key Vault'); |
| } | ||
|
|
||
| async function getKeyVaultAccounts(context: ICreateLinkerContext): Promise<KeyVaultJsonResponse> { | ||
| const url = `https://management.azure.com/subscriptions/${context.subscriptionId}/resources?$filter=resourceType eq 'Microsoft.KeyVault/vaults'&api-version=2015-11-01` |
There was a problem hiding this comment.
We don't want to use management.azure.com for these requests because then we don't support anything but the public cloud. I think if you check the context.subscription or maybe context.credentials you should see there's something called a resourceManagementEndpoint or something like that,
nturinski
reviewed
Aug 2, 2023
| return !context.keyVaultAccount; | ||
| } | ||
|
|
||
| private async getPicks(accounts: KeyVaultAccountJsonResponse[]): Promise<IAzureQuickPickItem<KeyVaultAccountJsonResponse>[]> { |
There was a problem hiding this comment.
This doesn't need to be async since you're calling getKeyVaultAccounts in the prompt.
| @@ -29,4 +31,17 @@ export class LinkerCreateStep extends AzureWizardExecuteStep<ICreateLinkerContex | |||
| public shouldExecute(context: ICreateLinkerContext): boolean { | |||
| return !context.linker; | |||
| } | |||
|
|
|||
| public getSourceResourceId(context: ICreateLinkerContext): string { | |||
There was a problem hiding this comment.
Doesn't really matter, but this can be private.
nturinski
previously approved these changes
Aug 2, 2023
nturinski
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for creating CosmosCD and Key Vault service connectors.