appservice: Refactor deployment code into steps #1554
Conversation
appservice/src/deploy/deploy.ts
Outdated
| // Docker values point to the user's specific image, which we don't want to track | ||
| return /^docker/i.test(linuxFxVersion) ? 'docker' : linuxFxVersion; | ||
| const innerContext: InnerDeployContext = Object.assign(context, { site, fsPath, client, aspPromise }); | ||
| const title: string = l10n.t('Deploying to function app "{0}"', site.fullName); |
There was a problem hiding this comment.
Function is used by App Service and Functions so title needs to either be generic or handle both cases.
| const title: string = l10n.t('Deploying to function app "{0}"', site.fullName); | |
| const title: string = l10n.t('Deploying to "{0}"', site.fullName); |
There was a problem hiding this comment.
I changed it to just "app".
| callback: (zipStream: Readable) => Promise<AzExtPipelineResponse | void> | ||
| }): Promise<AzExtPipelineResponse | void> { | ||
|
|
||
| function onFileSize(size: number): void { | ||
| context.telemetry.measurements.zipFileSize = size; | ||
| const zipFileSize = vscode.l10n.t('Zip package size: {0}', prettybytes(size)); | ||
| ext.outputChannel.appendLog(vscode.l10n.t('Zip package size: {0}', prettybytes(size)), { resourceName: site.fullName }); |
There was a problem hiding this comment.
| ext.outputChannel.appendLog(vscode.l10n.t('Zip package size: {0}', prettybytes(size)), { resourceName: site.fullName }); | |
| ext.outputChannel.appendLog(zipFileSize, { resourceName: site.fullName }); |
| import { Progress, ProgressLocation, l10n, window } from "vscode"; | ||
| import { InnerDeployContext } from "../IDeployContext"; | ||
|
|
||
| export abstract class DeployExecuteBaseStep extends AzureWizardExecuteStep<InnerDeployContext> { |
There was a problem hiding this comment.
DeployExecuteStepBase might be a better name.
|
Overall looks really good. I tested it myself with a few simple Function App deploys. |
|
Bump 👊 |
…-azuretools into nat/deploySteps
…-azuretools into nat/deploySteps
|
I think this is ready to review/approve btw. |
|
FYI, the zip deployment code has been modified on main. I don't know why there isn't any merge conflict. |
|
Oh never mind, I guess I still have |
|
I think everything is okay with this one. Gonna go ahead and just merge it with Alex's dismissed approval |
No description provided.