serviceconnector: Add children to validate activity log #1557
Conversation
| contextValue: `validateResult-${detail.name}`, | ||
| label: nonNullValue(detail.name), | ||
| iconPath: new ThemeIcon('error', new ThemeColor('testing.iconFailed')) | ||
| })); | ||
| throw new Error(detail.description); |
There was a problem hiding this comment.
Although one validation failed, I think it's best to still show all other failed/passed validations as activity children. Maybe throw the error after all the children are added?
There was a problem hiding this comment.
The portal currently only shows the one failure if the validation errors but I think it would be better to show all the checks.
There was a problem hiding this comment.
Actually tested this out and for some reason when there is an error the validation result only contains the failed check. So moving the error after all the children doesn't change anything.
There was a problem hiding this comment.
I'm not exactly sure why that happens. But that's fine
| linkerName?: string; | ||
|
|
||
| //Validation | ||
| validationResult?: ValidationResultItem[] |
There was a problem hiding this comment.
Where is this set or used?
There was a problem hiding this comment.
Was using it in a previous implementation but will remove since it is no longer used.
Here is how the validation success state looks:
Here is how the error state looks:
