Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Add changes to be compatible with the new tenant view #1789

Merged
merged 10 commits into from
Sep 19, 2024

Conversation

motm32
Copy link
Contributor

@motm32 motm32 commented Sep 9, 2024

See here for tenant view PR.

@motm32 motm32 marked this pull request as ready for review September 12, 2024 17:51
@motm32 motm32 requested a review from a team as a code owner September 12, 2024 17:51
@alexweininger
Copy link
Member

alexweininger commented Sep 16, 2024

Get the build to pass and then verify that all the changes are compatible with microsoft/vscode-azureresourcegroups#869 and then we can work on releasing this

@motm32
Copy link
Contributor Author

motm32 commented Sep 17, 2024

Get the build to pass and then verify that all the changes are compatible with microsoft/vscode-azureresourcegroups#869 and then we can work on releasing this

I have done some prleiminary testing with the updates to this package and the resources PR but going to do some more thorough testing today. Should be hopefully ready to go sometime tomorrow if testing goes well.

@alexweininger
Copy link
Member

Ok I think we're done changing function signatures. Can you make sure the doc comments are all up-to-date?

@alexweininger
Copy link
Member

alexweininger commented Sep 18, 2024

:shipit:

when we release this lets make sure we have a comprehensive changelog posted

@motm32 motm32 merged commit 097963c into main Sep 19, 2024
4 checks passed
@motm32 motm32 deleted the meganmott/tenantChanges branch September 19, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants