Refactor: upgrade configWatcher.ts disposal pattern#703
Merged
Conversation
Adopt enhanced disposal pattern from pylint with: - disposed flag to prevent handlers running after disposal - pending promise tracking to cancel in-flight operations - traceError for error handling in event callbacks This prevents race conditions when the extension deactivates while config change handlers are still executing. Part of #697 Ref: microsoft/vscode-python-tools-extension-template#290 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edvilme
force-pushed
the
phase4/configwatcher-disposal
branch
from
a14dcb4 to
dee9409
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the enhanced disposal pattern from pylint's configWatcher.ts:
disposedflag to prevent event handlers from running after disposalpendingpromise to cancel in-flight config change operationstraceErrorfor proper error handling in event callbacksThis prevents potential race conditions when the extension deactivates while config file change handlers are still executing.
Part of #697
Ref: microsoft/vscode-python-tools-extension-template#290