Add extensive end-to-end tests of IContainersClient
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
changed the title
IContainersClient
3 tasks
There was a problem hiding this comment.
PR Overview
This PR adds extensive end-to-end tests for IContainersClient and includes minor improvements in the Docker client behavior and documentation.
- Added support for a '--time' argument in the restart containers command.
- Clarified the time parameter documentation in ContainerClient contracts.
- Updated test descriptions to differentiate between unit and integration tests.
Reviewed Changes
| File | Description |
|---|---|
| packages/vscode-container-client/src/clients/DockerClientBase/DockerClientBase.ts | Added handling for the '--time' flag during container restart. |
| packages/vscode-container-client/src/contracts/ContainerClient.ts | Updated doc comments to specify that time values are in seconds. |
| packages/vscode-container-client/src/test/normalizeContainerState.test.ts | Renamed describe block to include '(unit)'. |
| packages/vscode-container-client/src/test/DockerComposeClient.test.ts | Updated describe blocks for clearer unit and integration test separation. |
| packages/vscode-container-client/src/test/DockerClient.test.ts | Renamed describe block to include '(unit)'. |
| packages/vscode-container-client/src/test/parseDockerRawPortString.test.ts | Renamed describe block to include '(unit)'. |
| packages/vscode-container-client/src/test/wslifyPath.test.ts | Renamed describe block to include '(unit)'. |
| packages/vscode-container-client/src/test/tryParseSize.test.ts | Renamed describe block to include '(unit)'. |
| packages/vscode-container-client/src/test/parseDockerLikeImageName.test.ts | Renamed describe block to include '(unit)'. |
| packages/vscode-container-client/src/test/commandLineBuilder.test.ts | Renamed describe block to include '(unit)'. |
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
karolz-ms
approved these changes
Mar 11, 2025
Comment on lines
+28
to
+32
| const runInWsl: boolean = false; // Set to true if running in WSL | ||
|
|
||
| // Supply to run the login/logout tests | ||
| const dockerHubUsername = ''; | ||
| const dockerHubPAT = ''; // Never commit this value!! |
There was a problem hiding this comment.
Here I am also wondering if env vars would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76