adding other cases too

microsoft · Feb 7, 2025 · d535584 · d535584
1 parent 60ed402
commit d535584
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/test/smoke/src/areas/preferences/preferences.test.ts b/test/smoke/src/areas/preferences/preferences.test.ts
@@ -29,8 +29,7 @@ export function setup(logger: Logger) {
 
 			await app.workbench.keybindingsEditor.updateKeybinding('workbench.action.toggleSidebarPosition', 'View: Toggle Primary Side Bar Position', 'ctrl+u', 'Control+U');
 
-			await app.code.dispatchKeybinding('ctrl+u');
-			await app.workbench.activitybar.waitForActivityBar(ActivityBarPosition.RIGHT);
+			await app.code.dispatchKeybinding('ctrl+u', () => app.workbench.activitybar.waitForActivityBar(ActivityBarPosition.RIGHT));
 		});
 	});
 
@@ -53,8 +52,9 @@ export function setup(logger: Logger) {
 			const app = this.app as Application;
 
 			await app.workbench.editors.newUntitledFile();
-			await app.code.dispatchKeybinding('enter');
-			await app.code.waitForElements('.line-numbers', false, elements => !!elements.length);
+			await app.code.dispatchKeybinding('enter', async () => {
+				await app.code.waitForElements('.line-numbers', false, elements => !!elements.length);
+			});
 
 			// Turn off line numbers
 			await app.workbench.settingsEditor.searchSettingsUI('editor.lineNumbers');

diff --git a/test/smoke/src/areas/search/search.test.ts b/test/smoke/src/areas/search/search.test.ts
@@ -23,11 +23,13 @@ export function setup(logger: Logger) {
 			const app = this.app as Application;
 			await app.workbench.search.openSearchViewlet();
 
-			await app.code.dispatchKeybinding('PageUp');
-			await app.workbench.search.hasActivityBarMoved();
+			await app.code.dispatchKeybinding('PageUp', async () => {
+				await app.workbench.search.hasActivityBarMoved();
+			});
 
-			await app.code.dispatchKeybinding('PageUp');
-			await app.workbench.search.hasActivityBarMoved();
+			await app.code.dispatchKeybinding('PageUp', async () => {
+				await app.workbench.search.hasActivityBarMoved();
+			});
 		});
 
 		it('searches for body & checks for correct result number', async function () {