Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add electron as an external for webpack #239134

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

devm33
Copy link
Contributor

@devm33 devm33 commented Jan 29, 2025

This should fix the issue where require('electron') does not resolve on the bundled extension after #238149

Note, I don't see how to bundle the extension locally to confirm that this is working.

cc #207867

@TylerLeonhardt
Copy link
Member

due to the nature of this change, we will hold off on it til Monday so we can let it bake in Insiders.

@TylerLeonhardt
Copy link
Member

You can trigger a bundled build by running:

npm run gulp vscode-darwin-arm64

Which will build the macOS ARM build.

You can see all of our targets with:

npm run gulp -- --tasks

@TylerLeonhardt TylerLeonhardt enabled auto-merge (squash) February 3, 2025 18:49
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the bundled code for GitHub & Microsoft auth extensions now require "electron"

@devm33
Copy link
Contributor Author

devm33 commented Feb 3, 2025

I verified that the bundled code for GitHub & Microsoft auth extensions now require "electron"

Thank you for verifying! 🎉

@TylerLeonhardt TylerLeonhardt merged commit 63d1401 into microsoft:main Feb 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants