make sure shellIntegration.cwd is set for reconnected terminals, fix bug for terminal suggest
#239148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Jan 30, 2025
|
Closing in favor of #239238 now that I figured out how reconnection for the capabilities occurs. |
auto-merge was automatically disabled
January 30, 2025 17:22
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #239027
fix #234672
Here is the key line, where we now pass in the cwd that gets set via reconnection properties to the
shellIntegrationAddonsuch that when command detection gets created, if the cwd detection has not been created yet (IE cwd has not been updated), we will create that and update its value.vscode/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
Line 782 in 1d37b27