Force an update after acquiring a token interactively #239535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make sure the account cache is up-to-date before the `acquireTokenInteractive` ends. Fixes #235327
TylerLeonhardt
commented
Feb 3, 2025
| @@ -233,7 +233,6 @@ export class MsalAuthProvider implements AuthenticationProvider { | |||
| const session = this.sessionFromAuthenticationResult(result, scopeData.originalScopes); | |||
| this._telemetryReporter.sendLoginEvent(session.scopes); | |||
| this._logger.info('[createSession]', `[${scopeData.scopeStr}]`, 'returned session'); | |||
| this._onDidChangeSessionsEmitter.fire({ added: [session], changed: [], removed: [] }); | |||
There was a problem hiding this comment.
This is redundant since the update() in the other file change will trigger this event.
TylerLeonhardt
commented
Feb 3, 2025
Comment on lines
+163
to
+168
| ); | ||
| if (this._isBrokerAvailable) { | ||
| await this._accountAccess.setAllowedAccess(result.account!, true); | ||
| } | ||
| // Force an update so that the account cache is updated | ||
| await this._update(); |
There was a problem hiding this comment.
This moves this stuff into the sequencer & adds a this._update() to force an update.
connor4312
added
the
candidate
connor4312
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make sure the account cache is up-to-date before the
acquireTokenInteractiveends.A greater fix is maybe turning the accounts cache to be a promise.. but I won't do that for a candidate.
Fixes #235327