Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use terminal font for terminal suggest #239543

Merged
merged 6 commits into from
Feb 5, 2025
Merged

use terminal font for terminal suggest #239543

merged 6 commits into from
Feb 5, 2025

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Feb 3, 2025 •
edited
Loading

fix #239095

@meganrogge meganrogge self-assigned this Feb 3, 2025
@meganrogge meganrogge requested a review from Tyriar February 3, 2025 23:05
@meganrogge meganrogge added this to the February 2025 milestone Feb 3, 2025
@meganrogge meganrogge enabled auto-merge (squash) February 3, 2025 23:05
@meganrogge meganrogge marked this pull request as draft February 3, 2025 23:13
auto-merge was automatically disabled February 3, 2025 23:13

Pull request was converted to draft

meganrogge
meganrogge commented Feb 5, 2025
View reviewed changes
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts
const letterSpacing: number = font.letterSpacing;
const fontWeight: string = this._configurationService.getValue('editor.fontWeight');

if (lineHeight <= 1) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taken from here

vscode/src/vs/editor/common/config/fontInfo.ts

Lines 63 to 74 in 9ada392

if (lineHeight === 0) {
lineHeight = GOLDEN_LINE_HEIGHT_RATIO * fontSize;
} else if (lineHeight < MINIMUM_LINE_HEIGHT) {
// Values too small to be line heights in pixels are in ems.
lineHeight = lineHeight * fontSize;
}
// Enforce integer, minimum constraints
lineHeight = Math.round(lineHeight);
if (lineHeight < MINIMUM_LINE_HEIGHT) {
lineHeight = MINIMUM_LINE_HEIGHT;
}

@meganrogge meganrogge marked this pull request as ready for review February 5, 2025 22:30
@meganrogge meganrogge enabled auto-merge (squash) February 5, 2025 22:30
@meganrogge meganrogge merged commit fc9297d into main Feb 5, 2025
8 checks passed
@meganrogge meganrogge deleted the merogge/font-config-2 branch February 5, 2025 22:43
@Tyriar Tyriar mentioned this pull request Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar left review comments

@legomushroom legomushroom legomushroom approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
February 2025
Development

Successfully merging this pull request may close these issues.

Terminal suggest items look crammed
3 participants
@meganrogge @legomushroom @Tyriar