Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable skipped test and fix sorting of dotfiles #239546

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Re-enable skipped test and fix sorting of dotfiles #239546

merged 3 commits into from
Feb 5, 2025

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 3, 2025

Part of #239532

@Tyriar Tyriar added this to the February 2025 milestone Feb 3, 2025
@Tyriar Tyriar self-assigned this Feb 3, 2025
@Tyriar Tyriar marked this pull request as draft February 3, 2025 23:27
@Tyriar
Copy link
Member Author

Tyriar commented Feb 5, 2025

Failure in product build only. Not locally or in regular CI:

  1 failing

  1) SimpleCompletionModel
       files and folders
         should handle many files and folders correctly:

      
      + expected - actual

         "CodeQL.yml"
         ".configurations"
         "CONTRIBUTING.md"
         ".devcontainer"
      +  ".npmrc"
      +  ".gitignore"
      +  ".editorconfig"
         "eslint.config.js"
      +  ".eslint-ignore"
         ".eslint-plugin-local"
         "extensions"
      +  ".gitattributes"
      +  ".git-blame-ignore-revs"
         ".github"
         "gulpfile.js"
         "LICENSE.txt"
      -  "node_modules"
      -  ".npmrc"
      +  ".lsifrc.json"
         ".nvmrc"
      -  ".gitignore"

@Tyriar Tyriar requested a review from meganrogge February 5, 2025 13:41
@Tyriar
Copy link
Member Author

Tyriar commented Feb 5, 2025

Queued product build to verify

@Tyriar Tyriar marked this pull request as ready for review February 5, 2025 13:43
@Tyriar Tyriar changed the title Re-enable skipped test Re-enable skipped test and fix sorting of dotfiles Feb 5, 2025
@sunarnokg

This comment was marked as spam.

Sign in to view
@Tyriar Tyriar merged commit 4072228 into main Feb 5, 2025
35 of 40 checks passed
@Tyriar Tyriar deleted the tyriar/239532_2 branch February 5, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
February 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @sunarnokg @meganrogge