Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab border and focus outline #239907

Open
wants to merge 2 commits into
base: release/1.97
Choose a base branch
from
Open

Fix tab border and focus outline #239907

wants to merge 2 commits into from
+6 −2

Conversation

benibenj
Copy link
Contributor

@benibenj benibenj commented Feb 7, 2025

fixes #239846

@benibenj benibenj requested a review from bpasero February 7, 2025 08:56
@benibenj benibenj self-assigned this Feb 7, 2025
@benibenj benibenj enabled auto-merge (squash) February 7, 2025 08:56
@benibenj benibenj disabled auto-merge February 7, 2025 09:11
bpasero
bpasero requested changes Feb 7, 2025
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benibenj hard to say this wouldnt cause other regressions, care to comment on your reasoning?

Maybe for recovery we revert the offending change and in insiders work on this fix?

@benibenj
Copy link
Contributor Author

benibenj commented Feb 7, 2025 •
edited
Loading

The reason I did not revert the commit is because there was a second one touching the same line of code (creating a merge conflict...) which I don't want to revert. Essentially the top 2 changes I've made revert the code to the initial state before the original fix I made in December (would be equivalent to reverting the commit). The last css statement I've added is to fix the original bug. I'm including it as I believe it is a simple fix but I could also remove that part

@bpasero bpasero added this to the January 2025 Recovery 2 milestone Feb 10, 2025
@bpasero bpasero added the candidate Issue identified as probable candidate for fixing in the next release label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@benibenj benibenj

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
January 2025 Recovery 2
Development

Successfully merging this pull request may close these issues.
2 participants
@benibenj @bpasero