Fix Terminal Icon Picker alignment and placement #241359
Open
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes & Improvements:
✅ Adjusted hover positioning logic to ensure correct placement.
✅ Added offsetX and offsetY values for better positioning.
✅ Improved layout calculations to handle different screen sizes and resolutions.
✅ Ensured consistency across various UI states.
How We Fixed It:
Identified the Issue: The icon picker was misaligned due to incorrect hover positioning.
Updated the Code: Modified the hover widget positioning in terminalIconPicker.ts.
Resolved Type Errors: Fixed TypeScript errors by ensuring compatibility with IHoverOptions.
Tested the Fix: Verified placement in multiple scenarios within the Codespace environment.
Committed & Pushed Changes: Created a feature branch (fix-terminal-icon-picker), committed the fix, and pushed it to the repository.
How to Test:
1.Pull the latest changes from the branch:
git checkout fix-terminal-icon-picker
git pull origin fix-terminal-icon-picker
2.Build and run the project:
yarn install
yarn watch
3.Open the Terminal Icon Picker and verify its correct positioning.
4.Ensure the hover behavior is aligned properly across different window sizes.
Fixes #211394