Add input latency tracking to nativeEditContext #278209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds input latency tracking to the native EditContext implementation by integrating calls to the inputLatency performance monitoring utility at key interaction points.
- Tracks user input events (keydown, keyup, beforeinput, textupdate, selectionchange) to measure input latency
- Integrates the existing
inputLatencyperformance monitoring utility frombase/browser/performance.js
Tyriar
commented
Nov 18, 2025
Comment on lines
173
to
+174
| this._register(editContextAddDisposableListener(this._editContext, 'textupdate', (e) => { | ||
| inputLatency.onInput(); |
Member
Author
There was a problem hiding this comment.
Wasn't totally sure about this one. Is there an equivalent to input for edit context?
dbaeumer
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #278180
cc @aiday-mar, @rwoll