-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding API endpoints #423
base: master
Are you sure you want to change the base?
Adding API endpoints #423
Conversation
Stay in touch project ERD
Friendship model
…l-scaffold into develop
Add the app functionlaities to the view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Niko,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
## Invalid Code Review Request
You have submitted a project, that does not follow Git flow. Please see [this](https://github.com/microverseinc/curriculum-transversal-skills/blob/main/git-github/articles/gitflow.md) link and follow Git flow.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
**_Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise._**
--------
Invalid Code Review Request **does not count** into the code reviews limit._
@SajjadAhmad14 I've left a message on Slack to explain the situation. Please do check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nikoescobal 🙋♀️,
STATUS APPROVED ✔
Your project is complete! There is nothing else to say other than... it's time to merge it 🔗 🚢
Congratulations! 🎉
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers 🥂 and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this PR, I did the following: