Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/colon time correct spaces #50

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Fix/colon time correct spaces #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfdc736
add handling for colon-separated time in correct_spaces
gardarjuto Sep 13, 2024
17645f5
add tests for colon-times in correct_spaces
gardarjuto Sep 13, 2024
62b7bfa
address comments regarding walrus and set
gardarjuto Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/tokenizer/tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3223,7 +3223,20 @@ def correct_spaces(s: str) -> str:
# "bensínstöðvar, -dælur og -tankar"
r[-1] = " -"
r.append(w)
elif TP_SPACE[last - 1][this - 1] and r:
elif (
TP_SPACE[last - 1][this - 1]
and r
and not (
# Special case for colon-separated time or duration
# such as "12:00", "3:15" or "37:02:29"
w.isnumeric()
and len(w) == 2
and len(r) >= 2
and r[-1] == ":"
and (p := r[-2].strip()).isnumeric()
and len(p) in {1, 2}
)
gardarjuto marked this conversation as resolved.
Show resolved Hide resolved
):
r.append(" " + w)
else:
r.append(w)
Expand Down
9 changes: 9 additions & 0 deletions test/test_tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,6 +1145,15 @@ def test_correct_spaces() -> None:
"Þetta er setning.Þetta er önnur setning.Líka.En hvað með þetta?"
)
assert s == "Þetta er setning. Þetta er önnur setning. Líka. En hvað með þetta?"
# Test that colon-separated times are not space-separated
s = t.correct_spaces("Klukkan er 12: 00 og ég ætla að fara út .")
assert s == "Klukkan er 12:00 og ég ætla að fara út."
s = t.correct_spaces("Tíminn byrjar kl . 4: 14 og klukkan er núna 5:00 .")
assert s == "Tíminn byrjar kl. 4:14 og klukkan er núna 5:00."
s = t.correct_spaces("Veislan verður kl . 12 : 00 - 14 : 00.")
assert s == "Veislan verður kl. 12:00-14:00."
s = t.correct_spaces("Hún kom í mark á tímanum 3 : 59 : 04 ,rétt fyrir lokin.")
assert s == "Hún kom í mark á tímanum 3:59:04, rétt fyrir lokin."


def test_abbrev() -> None:
Expand Down