Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: captcha use newest cacheManager component #3570

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (21023ad) 84.54% compared to head (33bb15f) 84.54%.
Report is 3 commits behind head on main.

Files Patch % Lines
packages/mock/src/creator.ts 25.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3570   +/-   ##
=======================================
  Coverage   84.54%   84.54%           
=======================================
  Files         486      486           
  Lines       46174    46192   +18     
  Branches     5526     5527    +1     
=======================================
+ Hits        39037    39054   +17     
- Misses       7097     7098    +1     
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy88840616 czy88840616 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jan 16, 2024
@czy88840616 czy88840616 merged commit 2ffce0a into main Jan 16, 2024
@czy88840616 czy88840616 deleted the fix_cache_in_captcha branch January 16, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Development

Successfully merging this pull request may close these issues.

2 participants