Adds Frequency Offset option to adjust the vertical freq to captured frequency center #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay getting back to you. Thank you for this. |
|
Sorry, work got intense else I would have responded sooner.
That change is perfectly fine!
Sincerely,
Josh Conway
…On Thu, Oct 1, 2020 at 9:54 AM Mike Walters ***@***.***> wrote:
Sorry for the delay getting back to you. Thank you for this.
It all looks good to me, except for one nitpick: I think it'd be better to
call it "Centre frequency". That matches what GNURadio and other tools call
it, and should make it's purpose more obvious to users. What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#169 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5S3KIUAXBG625QS4FEFJ3SISCY5ANCNFSM4QUU7K6A>
.
|
|
@jwcrawley I think the feature is nice. Can You rebase Your PR to the latest master branch (now main ^^) so that it can be easily merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature to implement a frequency offset, found just below the sample rate. If at 0, Inspectrum will function as it has before, with the center at 0 Hz, with 1/2 sample rate being the positive and negative bounds (eg: -10MHz to 10MHz centered around 0 Hz)
This feature shifts the 0 to the frequency that a user captured. For example, if a user was capturing a 30MHz window centering around 915MHz, they would see:
930MHz (upper bound)
915MHz (center)
900MHz (lower bound)
We also adjust this in accordance to the frequency and the sample rate in accordance how Inspectrum normally runs. We cannot detect this automatically, since IQ captures do not record it.