Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use viridis colormap #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use viridis colormap #204

wants to merge 1 commit into from

Conversation

tammojan
Copy link

@tammojan tammojan commented Oct 9, 2021

This uses the viridis colormap, and includes support for many other colormaps. I'm not totally sure if just including the header of https://github.com/yuki-koyama/tinycolormap is allowed license-wise, perhaps @yuki-koyama can comment. I think setting up cmake to use submodules just for one file be a bit of an overkill.

@yuki-koyama
Copy link

Hi, tinycolormap is MIT-licensed. So, it is allowed to directly copy and include (and even modify if necessary) the header file into any other projects, as long as the original copyright and permission notices are included somewhere.

@tammojan
Copy link
Author

tammojan commented Oct 9, 2021

Thanks @yuki-koyama! So only including the header file (and not deleting the copyright lines which are part of the header) is ok?

@yuki-koyama
Copy link

In my understanding, yes

@miek
Copy link
Owner

miek commented Mar 26, 2022

Thanks for the PR. I like the idea of this but I don't want to just swap out the current colormap with a new one.
I would be interested in a change that allowed different selectable colormaps though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants