Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color SigMF Annotations (v2) #208

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jacobagilbert
Copy link

@jacobagilbert jacobagilbert commented Mar 28, 2022

This is an update to #195 that provides essentially the same features through the much more sane presentation.sigmf-ext.md which can be found in this proposal to upstream it.

Example thus becomes:

  ...
  "annotations": [
    {
      "core:sample_start": 3383600,
      "core:sample_count": 197312,
      "core:freq_upper_edge": 201379186,
      "core:freq_lower_edge": 200727361,
      "core:description": "UNKNOWN",
      "presentation:color": "#55ffffff"
    },
    {
      "core:sample_start": 7327744,
      "core:sample_count": 397312,
      "core:freq_upper_edge": 198540829,
      "core:freq_lower_edge": 197964200,
      "core:description": "VALID",
      "presentation:color": "#90ee90"
    },
    {
      "core:sample_start": 5327744,
      "core:sample_count": 897312,
      "core:freq_upper_edge": 195540829,
      "core:freq_lower_edge": 194964200,
      "core:description": "ERROR",
      "presentation:color": "#db7093"
    },
    ...
  ]

The use of named colors is not technically supported by the extension, however any valid QColor string will work here.

@schneider42
Copy link
Collaborator

schneider42 commented Mar 30, 2022

Nice :)

Two thoughts:

  • Let's merge the upstream change first ;)
  • I guess at some point we need to think about if there should be some kind of SigMF options tab in the main window.

Edit: And maybe we should even not parse named colors? It might prevent people from producing invalid meta data and thinking it's OK...

this is done through the `presentation` sigmf extensions simple,
annotation by annotation color setting mechanism

Signed-off-by: Jacob Gilbert <[email protected]>
@jacobagilbert jacobagilbert force-pushed the add_color_spec_to_annotation_boxes branch from 41ac4c3 to 1d976fe Compare April 7, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants