a11y: add aria-label to icon-only buttons#219
Merged
garrity-miepub merged 1 commit intomainfrom May 2, 2026
Merged
Conversation
- OnboardingWizard: Back/Next buttons (icon-only on mobile) - ServiceCard: Delete/Edit buttons (had title only) - NotificationCenter: Dismiss × button - AuthDialog: 3 password visibility toggle buttons - AIChat: Clear chat button (had title only) - CommandPalette: Clear search button - Sidebar: Collapsed nav items (had title only) Fixes button-name violations in ~20 stories.
Deploying ui with
|
| Latest commit: |
2c7c877
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b70ba671.ui-6d0.pages.dev |
| Branch Preview URL: | https://accessibility-a11y-button-la.ui-6d0.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR improves accessibility across the component library by adding accessible names (aria-label) to icon-only buttons (and collapsed navigation items), addressing “button-name” violations in Storybook.
Changes:
- Add conditional
aria-labelto collapsedSidebarnav group/item triggers. - Add
aria-labelto various icon-only action buttons (delete/edit, dismiss, clear search/chat). - Add
aria-labelto onboarding navigation buttons and password visibility toggles.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/Sidebar/Sidebar.tsx | Adds conditional aria-label for collapsed nav group/item controls. |
| src/components/ServiceCard/ServiceCard.tsx | Adds aria-label to icon-only delete/edit action buttons. |
| src/components/OnboardingWizard/OnboardingWizard.tsx | Adds aria-label to Back/Next buttons for mobile icon-only rendering. |
| src/components/NotificationCenter/NotificationCenter.tsx | Adds aria-label to the dismiss (×) button. |
| src/components/CommandPalette/CommandPalette.tsx | Adds aria-label to the clear-search (X) button. |
| src/components/AuthDialog/AuthDialog.tsx | Adds aria-label to password visibility toggle buttons. |
| src/components/AI/AIChat.tsx | Adds aria-label to the clear-chat button. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes button-name violations in ~20 stories.