replace constant_time_compare with hmac.compare_digest#58
Closed
jllopezpino wants to merge 4 commits intomikeboers:masterfrom
Closed
replace constant_time_compare with hmac.compare_digest#58jllopezpino wants to merge 4 commits intomikeboers:masterfrom
jllopezpino wants to merge 4 commits intomikeboers:masterfrom
Conversation
invisiblek
reviewed
Jul 16, 2021
| from PIL import Image, ImageFilter | ||
| from flask import request, current_app, send_file, abort | ||
|
|
||
| try: |
There was a problem hiding this comment.
you need to keep the import of Signer
1 task
Owner
|
Hi @jllopezpino, Thanks for your patience. I believe @invisiblek is correct, and it won't work as-is. I think we ought to:
|
Author
I would go that way. But you are the maintainer here : ) |
…sizer Lets migrate to flask image resizer
Author
|
#60 already covers this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Mike,
My commit should fix the problem that I reported on #57.
It would be great if you can review it and release a new version to pypi because latest itsdangerous version on pypi breaks this package.
Thanks!