add optional data_path parameter to generate_spectra_splits#1
Open
aaronwtr wants to merge 4 commits intomims-harvard:mainfrom
Open
add optional data_path parameter to generate_spectra_splits#1aaronwtr wants to merge 4 commits intomims-harvard:mainfrom
aaronwtr wants to merge 4 commits intomims-harvard:mainfrom
Conversation
Optional parameter to allow people to specify a relative path where the SPECTRA splits will be stored
optional data_path variable. If specified, the SPECTRA splits will be saved at the specified path, it not, they will be placed in root folder, as they were before.
this commit fixes an integration bug where the spectra graph wasn't stored at the correct location similarly to the spectra splits
this commit fixes an integration bug where the spectra graph wasn't stored at the correct location similarly to the spectra splits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added an optional data_path parameter that can be used to specify path where the spectra splits can be saved to. If left empty, the folder gets put in the root directory, as it was before. Beware: when specifying location, make sure to format the path as
<path/to/folder/>, with a final/. This is necessary to preserve the original implementation where the folders get written to the root folder without adding to much additional logic.