Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google search suggestions #2075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flightmansam
Copy link
Contributor

Added search url (for english only).
Tentatively disabled search engine check in instantAnswerPlugin

Added search url (for english only).
Tenatitively disabled search engine check in instantAnswerPlugin
@flightmansam flightmansam changed the title Initial functionality google-search-suggestions Google search suggestions Aug 22, 2022
@flightmansam
Copy link
Contributor Author

TODO:
Decide whether instantAnswerPlugin needs to fetch a preferences option to always provide instant answers using DDG even if the default search engine isn't DDG.

@flightmansam
Copy link
Contributor Author

@PalmerAL Is this okay to merge?

@PalmerAL
Copy link
Collaborator

I don't want to use the Google URL unless they have an official API we can use that they won't try to block. We could make this an option when you set a custom search engine though.

@gribanoveu
Copy link

Is any telemetry being sent to google at this point?

@flightmansam
Copy link
Contributor Author

Not any more than manually putting in the URL in any browser.

@PalmerAL
Copy link
Collaborator

Oh, I'm realizing I never followed up on the DDG part of this PR, sorry. I believe the original reason for that restriction was due to a restriction in DDGs API terms, although I can't find anything supporting that anymore. They've since deprecated the API entirely and deleted all the documentation, so we really should figure out an alternative to use; I'm not sure at the moment what that would be though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants