Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Types: Skip .test.yml files when linting/applying #4772

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 17, 2024

Summary

These files are not actually rule types and will make linting and
applying rule types fail.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

These files are not actually rule types and will make linting and
applying rule types fail.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@coveralls
Copy link

coveralls commented Oct 17, 2024

Pull Request Test Coverage Report for Build 11382889947

Details

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 54.703%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/util/cli/cli.go 0 7 0.0%
Totals Coverage Status
Change from base Build 11380841120: -0.01%
Covered Lines: 14941
Relevant Lines: 27313

💛 - Coveralls

@JAORMX JAORMX merged commit 1d818b1 into mindersec:main Oct 17, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants