Move objects even when sticky blocks are involved#598
Open
TurkeyMcMac wants to merge 4 commits intominetest-mods:masterfrom
Open
Move objects even when sticky blocks are involved#598TurkeyMcMac wants to merge 4 commits intominetest-mods:masterfrom
TurkeyMcMac wants to merge 4 commits intominetest-mods:masterfrom
Conversation
TurkeyMcMac
force-pushed
the
move-objects
branch
from
d8ee8f8 to
8e87671
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #596. Fixes #462.
This significantly complicates the code. I had to add some special cases to replicate the old behavior. For example, when a sticky piston retracts while pulling no blocks, only objects touching the face of the piston head should be pulled. I could simplify the code if this behavior does not need preservation. One thing that did change in the pulling of objects is that mvps no longer pull objects downwards. I think the new behavior is more consistent with the lack of pulling in other directions, although it could affect elevators a bit.
Objects are still dragged on the sides of moving stacks, but no longer are dragged into solid nodes.