Skip to content

Refactor <Notifications /> with hooks #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edumoreira1506 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor <Notifications /> with hooks #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 42 additions & 50 deletions src/Notifications.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,59 +4,51 @@ import { CSSTransitionGroup } from 'react-transition-group';
import classnames from 'classnames';
import Notification from './Notification';

class Notifications extends React.Component {
static propTypes = {
notifications: PropTypes.array.isRequired,
onRequestHide: PropTypes.func,
enterTimeout: PropTypes.number,
leaveTimeout: PropTypes.number
const Notifications = ({
notifications = [],
onRequestHide = () => { },
enterTimeout = 400,
leaveTimeout = 400
}) => {
const handleRequestHide = notification => () => {
if (onRequestHide) onRequestHide(notification);
};

static defaultProps = {
notifications: [],
onRequestHide: () => {
},
enterTimeout: 400,
leaveTimeout: 400
};

handleRequestHide = notification => () => {
const { onRequestHide } = this.props;
if (onRequestHide) {
onRequestHide(notification);
}
};
const className = classnames('notification-container', {
'notification-container-empty': notifications.length === 0
});

render() {
const { notifications, enterTimeout, leaveTimeout } = this.props;
const className = classnames('notification-container', {
'notification-container-empty': notifications.length === 0
});
return (
<div className={className}>
<CSSTransitionGroup
transitionName="notification"
transitionEnterTimeout={enterTimeout}
transitionLeaveTimeout={leaveTimeout}
>
{notifications.map((notification) => {
const key = notification.id || new Date().getTime();
return (
<Notification
key={key}
type={notification.type}
title={notification.title}
message={notification.message}
timeOut={notification.timeOut}
onClick={notification.onClick}
onRequestHide={this.handleRequestHide(notification)}
/>
);
})}
</CSSTransitionGroup>
</div>
);
}
return (
<div className={className}>
<CSSTransitionGroup
transitionName="notification"
transitionEnterTimeout={enterTimeout}
transitionLeaveTimeout={leaveTimeout}
>
{notifications.map((notification) => {
const key = notification.id || new Date().getTime();
return (
<Notification
key={key}
type={notification.type}
title={notification.title}
message={notification.message}
timeOut={notification.timeOut}
onClick={notification.onClick}
onRequestHide={handleRequestHide(notification)}
/>
);
})}
</CSSTransitionGroup>
</div>
);
}

Notifications.propTypes = {
notifications: PropTypes.array.isRequired,
onRequestHide: PropTypes.func,
enterTimeout: PropTypes.number,
leaveTimeout: PropTypes.number
};

export default Notifications;