fix getElementsByTagName error #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initialization should be done once to avoid referencing the wrong function. In this case `options.getThumbBoundsFn = options.getThumbBoundsFn || getThumbBoundsFn;` was referencing the previous getThumbBoundsFn.
|
@minhtranite please merge |
|
This is also a problem for us! Merging would be nice. regards |
tzachyrm
reviewed
Apr 11, 2018
src/PhotoSwipeGallery.js
Outdated
|
|
||
| showPhotoSwipe = itemIndex => (e) => { | ||
| showPhotoSwipe = index => (e) => { | ||
| console.log('click photo') |
src/PhotoSwipeGallery.js
Outdated
| state = { | ||
| isOpen: this.props.isOpen, | ||
| options: this.props.options | ||
| options: this.props.options || this.getThumbBoundsFn |
There was a problem hiding this comment.
if this.props.options is undefined, state.options will be a function instead of an object?
Author
|
@tzachyrm good point! Looking at it now, I am not sure why I did that. |
|
@minhtranite can you please merge this? |
|
For some reason it doesn't fix the mentioned issue. There's another fork of this branch at vildehav/react-photoswipe and it solves the issue for me. It's also available on npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #35
closes #23