feat(integrations): automatically disable googlereader/fever when not used #3543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fguillot
reviewed
Jul 30, 2025
fguillot
requested changes
Jul 31, 2025
jvoisin
added a commit
to jvoisin/v2
that referenced
this pull request
Aug 2, 2025
… used miniflux#3543 When there is no user of Fever/GoogleReader, there is no need to expose their endpoints. This reduces quite a bit the exposition surface of miniflux, while not breaking any existing deployments, and is pretty self-contained.
|
You're right, I should have tested this more thoroughly. I played with it locally, with fever/google reader enabled/disabled, and it seems to be working properly now. |
jvoisin
added a commit
to jvoisin/v2
that referenced
this pull request
Aug 2, 2025
… used miniflux#3543 When there is no user of Fever/GoogleReader, there is no need to expose their endpoints. This reduces quite a bit the exposition surface of miniflux, while not breaking any existing deployments, and is pretty self-contained.
jvoisin
added a commit
to jvoisin/v2
that referenced
this pull request
Aug 3, 2025
… used miniflux#3543 When there is no user of Fever/GoogleReader, there is no need to expose their endpoints. This reduces quite a bit the exposition surface of miniflux, while not breaking any existing deployments, and is pretty self-contained.
There was a problem hiding this comment.
Pull Request Overview
This PR automatically disables Fever and Google Reader API endpoints when no users have these integrations enabled, reducing the attack surface of Miniflux without breaking existing deployments.
- Adds database queries to check if Fever and Google Reader integrations are actively used
- Implements middleware to return unauthorized responses when integrations are disabled
- Integrates the new middleware into both Fever and Google Reader API routing
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/storage/integration.go | Adds IsFeverUsed() and IsGoogleReaderUsed() methods to check if integrations are enabled |
| internal/fever/middleware.go | Adds middleware to return 401 when Fever is not used by any user |
| internal/fever/handler.go | Integrates the new authorization middleware into Fever routing |
| internal/googlereader/middleware.go | Adds middleware to return 401 when Google Reader is not used by any user |
| internal/googlereader/handler.go | Integrates the new authorization middleware into Google Reader routing |
jvoisin
added a commit
to jvoisin/v2
that referenced
this pull request
Aug 3, 2025
… used miniflux#3543 When there is no user of Fever/GoogleReader, there is no need to expose their endpoints. This reduces quite a bit the exposition surface of miniflux, while not breaking any existing deployments, and is pretty self-contained.
jvoisin
added a commit
to jvoisin/v2
that referenced
this pull request
Sep 16, 2025
… used miniflux#3543 When there is no user of Fever/GoogleReader, there is no need to expose their endpoints. This reduces quite a bit the exposition surface of miniflux, while not breaking any existing deployments, and is pretty self-contained.
jvoisin
added a commit
to jvoisin/v2
that referenced
this pull request
Sep 16, 2025
… used miniflux#3543 When there is no user of Fever/GoogleReader, there is no need to expose their endpoints. This reduces quite a bit the exposition surface of miniflux, while not breaking any existing deployments, and is pretty self-contained.
… used miniflux#3543 When there is no user of Fever/GoogleReader, there is no need to expose their endpoints. This reduces quite a bit the exposition surface of miniflux, while not breaking any existing deployments, and is pretty self-contained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no user of Fever/GoogleReader, there is no need to expose their endpoints. This reduces quite a bit the exposition surface of miniflux, while not breaking any existing deployments, and is pretty self-contained.