Skip to content

refactor(css): use css to scale svg icons #3681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(css): use css to scale svg icons #3681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/template/functions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func (f *funcMap) Map() template.FuncMap {
"theme_color": model.ThemeColor,
"icon": func(iconName string) template.HTML {
return template.HTML(fmt.Sprintf(
`<svg class="icon" aria-hidden="true"><use href="%s#icon-%s"/></svg>`,
`<svg aria-hidden="true"><use href="%s#icon-%s"/></svg>`,
route.Path(f.router, "appIcon", "filename", "sprite.svg"),
iconName,
))
Expand Down
10 changes: 6 additions & 4 deletions internal/ui/static/css/common.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,8 @@ a:hover {
white-space: nowrap;
}

#header-menu .icon,
.page-header ul a .icon {
#header-menu a>svg,
.page-header ul a>svg {
margin-bottom: 2px;
}

Expand Down Expand Up @@ -929,14 +929,16 @@ article.category-has-unread {
}

/* Icons */
.icon,
a>svg,
button>svg,
.icon-label {
vertical-align: text-bottom;
display: inline-block;
margin-right: 2px;
}

.icon {
a>svg,
button>svg {
width: 16px;
height: 16px;
}
Expand Down
Loading