-
Notifications
You must be signed in to change notification settings - Fork 572
Add idp openid accesskey
commands
#5182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces a new set of commands for managing OpenID access key pairs for MinIO, mirroring existing functionality for admin and LDAP access keys. The changes add new command files for access key list, info, enable, disable, edit, and remove operations, update auto-completion for the new commands, and refactor message types to promote consistency.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
cmd/idp-openid.go | Added a new OpenID access key command entry to the command list. |
cmd/idp-openid-accesskey.go | Introduced the base command and subcommands for OpenID access key management. |
cmd/idp-openid-accesskey-remove.go | Added the remove command for OpenID access keys, using the common message type. |
cmd/idp-openid-accesskey-list.go | Created a list command to display OpenID access keys with various filtering flags. |
cmd/idp-openid-accesskey-info.go | Added an info command to show details for specified OpenID access key pairs. |
cmd/idp-openid-accesskey-enable.go | Implemented the enable command for OpenID access keys. |
cmd/idp-openid-accesskey-edit.go | Added the edit command for modifying OpenID access keys with a help template update. |
cmd/idp-openid-accesskey-disable.go | Implemented the disable command for OpenID access keys. |
cmd/idp-ldap-accesskey-remove.go | Refactored message type usage to the common accesskeyMessage for removal. |
cmd/idp-ldap-accesskey-list.go | Updated flag handling and URL parsing for LDAP access key listing. |
cmd/idp-ldap-accesskey-info.go | Simplified LDAP access key info output by replacing the legacy message type. |
cmd/idp-ldap-accesskey-enable.go | Refactored to use the common accesskeyMessage type for enabling access keys. |
cmd/idp-ldap-accesskey-edit.go | Refactored to use the common accesskeyMessage type for editing access keys. |
cmd/idp-ldap-accesskey-create.go | Updated to use the common message type for creating LDAP access keys. |
cmd/idp-ldap-accesskey-create-with-login.go | Updated to use the common message type for creating LDAP access keys with login. |
cmd/auto-complete.go | Added auto-completion entries for all new OpenID access key command variants. |
cmd/admin-accesskey-info.go | Extended admin access key info handling to include provider-specific details. |
Comments suppressed due to low confidence (1)
cmd/idp-openid.go:31
- [nitpick] Ensure consistent naming conventions for OpenID commands; consider using uniform capitalization (e.g., 'idpOpenidAccesskeyCmd') to align with other command names.
idpOpenIDAccesskeyCmd,
Co-authored-by: Copilot <[email protected]>
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Adds
mc idp openid accesskey
commands that copy functionality formc admin accesskey
andmc idp ldap accesskey
.Does not include
create
as openid requires login to access info.Motivation and Context
Fixes #5086
How to test this PR?
Types of changes
Checklist:
commit-id
orPR #
here)