Skip to content

Conversation

dormanze
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

The current ping command outputs a summarized result each time, making it impossible to obtain real-time information. Referring to the implementation of the Linux ping command, each ping prints the real-time response time. After canceling the context or reaching the execution count, it automatically prints the summary result and beautifies the output in a tabular format.

Motivation and Context

Obtain real-time response times and print summary information after stopping command execution.

How to test this PR?

before:
image
after:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@dormanze dormanze closed this Jul 24, 2025
@dormanze dormanze reopened this Jul 24, 2025
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good. couple of minor ones

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Why not.

@dormanze dormanze requested a review from shtripat July 25, 2025 01:06
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 7394ce0 into minio:master Aug 13, 2025
5 checks passed
@dormanze dormanze deleted the ping branch September 12, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants