Skip to content

Remove deprecation warning on Django 2.0 and newer - #67

Open
Pacu2 wants to merge 1 commit into
masterfrom
fix/remove-deprecation-warning-on-django-2.0+
Open

Remove deprecation warning on Django 2.0 and newer#67
Pacu2 wants to merge 1 commit into
masterfrom
fix/remove-deprecation-warning-on-django-2.0+

Conversation

@Pacu2

@Pacu2 Pacu2 commented Oct 4, 2018

Copy link
Copy Markdown

Latest Pytest throws deprecation errors straight into the console, after merging this PR there will be one log less.

context kwarg will be deprecated in Django 3.0, and was dropped since Django 2.0

Comment thread django_prices/models.py
super(MoneyField, self).__init__(verbose_name, **kwargs)

def from_db_value(self, value, expression, connection, context):
def from_db_value(self, value, *args, **kwargs):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need *args here?

@maarcingebala
maarcingebala removed their request for review September 3, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants