Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to handle name change from 3PC -> PArSEC #11

Merged
merged 2 commits into from
May 7, 2024

Conversation

maurermi
Copy link
Contributor

This PR updates the codebase to handle the name change of 3PC to PArSEC. There are two commits in this PR currently, the first updates occurrences of 3PC to parsec, and the second updates occurrences of "phase two"

Modify string literals to contain parsec where 3pc is
currently expected.

Signed-off-by: Michael Maurer <[email protected]>
Update variable names, comments where "Phase Two" is
mentioned to reference PArSEC instead

Signed-off-by: Michael Maurer <[email protected]>
@HalosGhost
Copy link
Collaborator

Conditional T-ACK. Just to double-check: there are no default component configurations selected for parsec, and only four component roles are present (agent, shard, ticket machine, generator). Is this expected?

@maurermi
Copy link
Contributor Author

@HalosGhost from what I can tell, that is how the test controller currently operates for 3pc, though it may make sense to add default values. Also, the four components you listed should be all that is required (system core is an agent, ticket machine, and shard, and the load generator acts like a set of users)

@HalosGhost
Copy link
Collaborator

HalosGhost commented Jul 10, 2023

I think adding a default configuration is an incredibly good idea so that it's easy for people to dip their toes in.

Scratching the above (opened #16 as a future item) so this isn't blocked. Given that I've already t-ACK'd; if my in-progress testing of #12 is successful, it will be merged and should automatically close this.

Copy link
Collaborator

@HalosGhost HalosGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there's an open question on #12; merging!

@HalosGhost HalosGhost merged commit 41ea652 into mit-dci:trunk May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants