cosmetic changes

.github/workflows/CI.yml

@@ -11,15 +11,16 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.ref }}
           fetch-depth: 0
 
-      - uses: actions/setup-node@v1
+      - name: "Setup node"
+        uses: actions/setup-node@v4
         with:
-          node-version: ">=14"
-          check-latest: true
+          node-version: "lts/*"
+          #cache: "npm"
 
       - name: Install Salesforce CLI + Scanner
         run: |
@@ -29,6 +30,7 @@ jobs:
           sf plugins install @salesforce/sfdx-scanner
 
       - name: Run SFDX Scanner - Report findings as comments
+        if: github.event_name == 'pull_request'
         uses: mitchspano/[email protected]
         with:
           severity-threshold: 4
@@ -37,6 +39,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Authenticate into DevHub
+        id: authenticate
         run: |
           echo "${SALESFORCE_JWT_SECRET_KEY}" > server.key
           sf org login jwt --client-id ${{ secrets.SALESFORCE_CONSUMER_KEY }} --jwt-key-file server.key --username ${{ secrets.SALESFORCE_DEVHUB_USERNAME}} --set-default-dev-hub --alias devhub

.husky/_/pre-commit

@@ -0,0 +1 @@
+npm run precommit

.prettierrc

@@ -1,15 +1,81 @@
 {
-	"plugins": ["prettier-plugin-apex"],
+	"arrowParens": "avoid",
+	"bracketSpacing": true,
+	"bracketSameLine": true,
+	"printWidth": 100,
+	"semi": true,
+	"singleQuote": true,
 	"trailingComma": "none",
+	"endOfLine": "lf",
+	"apexInsertFinalNewline": false,
 	"useTabs": true,
 	"overrides": [
 		{
 			"files": "**/lwc/**/*.html",
 			"options": { "parser": "lwc" }
 		},
+		{
+			"files": "*.{cls,trigger}",
+			"options": { "parser": "apex", "tabWidth": 2, "useTabs": true }
+		},
+		{
+			"files": "*.trigger",
+			"options": { "printWidth": 200 }
+		},
 		{
 			"files": "*.{cmp,page,component}",
-			"options": { "parser": "html" }
+			"options": {
+				"parser": "html",
+				"useTabs": true,
+				"htmlWhitespaceSensitivity": "css"
+			}
+		},
+		{
+			"files": "*.{apex,soql}",
+			"options": { "parser": "apex-anonymous" }
+		},
+		{
+			"files": "*.{yml,yaml}",
+			"options": { "parser": "yaml", "tabWidth": 2, "useTabs": false }
+		},
+		{
+			"files": ".prettier*",
+			"options": { "parser": "json", "printWidth": 80, "useTabs": true }
+		},
+		{
+			"files": "*.xml",
+			"options": {
+				"parser": "xml",
+				"useTabs": true,
+				"singleQuote": false,
+				"xmlSelfClosingSpace": true
+			}
+		},
+		{
+			"files": ["**/pmd/*.xml", "*ruleset*.xml", "config/**/*.xml"],
+			"options": {
+				"parser": "xml",
+				"xmlSelfClosingSpace": true,
+				"xmlWhitespaceSensitivity": "ignore"
+			}
+		},
+		{
+			"files": "*meta.xml",
+			"options": {
+				"parser": "xml",
+				"useTabs": false,
+				"xmlSelfClosingSpace": false
+			}
+		},
+		{
+			"files": "*.json",
+			"options": {
+				"parser": "json-stringify",
+				"useTabs": false,
+				"tabWidth": 2
+			}
 		}
-	]
+	],
+	"plugins": ["prettier-plugin-apex", "@prettier/plugin-xml"],
+	"$schema": "https://json.schemastore.org/prettierrc"
 }

package.json

@@ -4,33 +4,17 @@
 	"version": "1.0.0",
 	"description": "Apex Trigger Actions Framework",
 	"scripts": {
-		"lint": "npm run lint:lwc && npm run lint:aura",
-		"lint:aura": "eslint **/aura/**",
-		"lint:lwc": "eslint **/lwc/**",
-		"test": "npm run test:unit",
-		"test:unit": "sfdx-lwc-jest",
-		"test:unit:watch": "sfdx-lwc-jest --watch",
-		"test:unit:debug": "sfdx-lwc-jest --debug",
-		"test:unit:coverage": "sfdx-lwc-jest --coverage",
-		"prettier": "prettier --write \"**/*.{cls,cmp,component,css,html,js,json,md,page,trigger,yaml,yml}\"",
-		"prettier:verify": "prettier --list-different \"**/*.{cls,cmp,component,css,html,js,json,md,page,trigger,yaml,yml}\""
+		"precommit": "lint-staged",
+		"prepare": "husky",
+		"prettier": "prettier --write \"**/*.{cls,cmp,component,css,html,js,json,md,page,trigger,xml,yaml,yml}\"",
+		"prettier:verify": "prettier --list-different \"**/*.{cls,cmp,component,css,html,js,json,md,page,trigger,xml,yaml,yml}\""
 	},
 	"devDependencies": {
-		"@prettier/plugin-xml": "^0.13.1",
-		"@salesforce/eslint-config-lwc": "^0.11.1",
-		"@salesforce/eslint-plugin-aura": "^2.0.0",
-		"@salesforce/sfdx-lwc-jest": "^0.10.4",
-		"eslint": "^7.24.0",
-		"eslint-config-prettier": "^8.1.0",
-		"husky": "^6.0.0",
-		"lint-staged": "^10.5.4",
-		"prettier": "3.0.2",
-		"prettier-plugin-apex": "2.0.1"
-	},
-	"husky": {
-		"hooks": {
-			"pre-commit": "lint-staged"
-		}
+		"@prettier/plugin-xml": "^3.4.1",
+		"husky": "^9.1.7",
+		"lint-staged": "^15.5.0",
+		"prettier": "3.5.3",
+		"prettier-plugin-apex": "2.2.5"
 	},
 	"lint-staged": {
 		"**/*.{cls,cmp,component,css,html,js,json,md,page,trigger,xml,yaml,yml}": [

sfdx-project.json

@@ -45,4 +45,4 @@
 		"Trigger Actions [email protected]": "04tKY000000PdZJYA0",
 		"Trigger Actions [email protected]": "04tKY000000PdZOYA0"
 	}
-}
+}

trigger-actions-framework/main/default/classes/FinalizerHandler.cls

@@ -121,10 +121,7 @@ public with sharing virtual class FinalizerHandler {
 	 * @param finalizerMetadata The metadata of the finalizer to execute.
 	 * @param context The context to pass to the finalizer's `execute` method.
 	 */
-	private void callReferencedFinalizer(
-		DML_Finalizer__mdt finalizerMetadata,
-		Context context
-	) {
+	private void callReferencedFinalizer(DML_Finalizer__mdt finalizerMetadata, Context context) {
 		Object dynamicInstance;
 		String className = finalizerMetadata.Apex_Class_Name__c;
 		if (FinalizerHandler.isBypassed(className)) {
@@ -166,9 +163,7 @@ public with sharing virtual class FinalizerHandler {
 	}
 
 	private void handleFinalizerException(String errorFormat, String className) {
-		throw new FinalizerException(
-			String.format(errorFormat, new List<String>{ className })
-		);
+		throw new FinalizerException(String.format(errorFormat, new List<String>{ className }));
 	}
 
 	/**
@@ -178,10 +173,7 @@ public with sharing virtual class FinalizerHandler {
 	 * @param requiredPermission The required permission for the finalizer.
 	 * @return True if bypassed, false otherwise.
 	 */
-	private boolean isBypassed(
-		String bypassPermission,
-		String requiredPermission
-	) {
+	private boolean isBypassed(String bypassPermission, String requiredPermission) {
 		return (bypassPermission != null && permissionMap.get(bypassPermission)) ||
 			(requiredPermission != null && !permissionMap.get(requiredPermission));
 	}
@@ -192,10 +184,7 @@ public with sharing virtual class FinalizerHandler {
 	 */
 	private void populatePermissionMap(String permissionName) {
 		if (permissionName != null && !permissionMap.containsKey(permissionName)) {
-			permissionMap.put(
-				permissionName,
-				FeatureManagement.checkPermission(permissionName)
-			);
+			permissionMap.put(permissionName, FeatureManagement.checkPermission(permissionName));
 		}
 	}
 
@@ -231,8 +220,7 @@ public with sharing virtual class FinalizerHandler {
 		 *  equal to, or greater than the specified object.
 		 */
 		public Integer compareTo(Object other) {
-			Decimal difference = (this.metadata.Order__c -
-			((FinalizerSorter) other).metadata.Order__c);
+			Decimal difference = (this.metadata.Order__c - ((FinalizerSorter) other).metadata.Order__c);
 			return difference < 0 ? -1 : difference == 0 ? 0 : 1;
 		}
 	}
@@ -249,4 +237,4 @@ public with sharing virtual class FinalizerHandler {
 	 */
 	private class FinalizerException extends Exception {
 	}
-}
+}

trigger-actions-framework/main/default/classes/FinalizerHandlerTest.cls

@@ -94,10 +94,7 @@ private with sharing class FinalizerHandlerTest {
 	@IsTest
 	private static void staticallyBypassedFinalizerShouldNotExecute() {
 		handler.allFinalizers = new List<DML_Finalizer__mdt>{
-			new DML_Finalizer__mdt(
-				Apex_Class_Name__c = TEST_FOO_FINALIZER,
-				Order__c = 1
-			)
+			new DML_Finalizer__mdt(Apex_Class_Name__c = TEST_FOO_FINALIZER, Order__c = 1)
 		};
 
 		FinalizerHandler.bypass(TEST_FOO_FINALIZER);
@@ -150,14 +147,8 @@ private with sharing class FinalizerHandlerTest {
 	@IsTest
 	private static void finalizersShouldExecuteInOrder() {
 		handler.allFinalizers = new List<DML_Finalizer__mdt>{
-			new DML_Finalizer__mdt(
-				Apex_Class_Name__c = TEST_FOO_FINALIZER,
-				Order__c = 1
-			),
-			new DML_Finalizer__mdt(
-				Apex_Class_Name__c = TEST_BAR_FINALIZER,
-				Order__c = 2
-			)
+			new DML_Finalizer__mdt(Apex_Class_Name__c = TEST_FOO_FINALIZER, Order__c = 1),
+			new DML_Finalizer__mdt(Apex_Class_Name__c = TEST_BAR_FINALIZER, Order__c = 2)
 		};
 
 		handler.handleDynamicFinalizers();
@@ -213,10 +204,7 @@ private with sharing class FinalizerHandlerTest {
 		System.Assert.isNotNull(myException, EXCEPTION_SHOULD_BE_THROWN);
 
 		System.Assert.areEqual(
-			String.format(
-				FinalizerHandler.INVALID_TYPE_ERROR_FINALIZER,
-				new List<String>{ MY_CLASS }
-			),
+			String.format(FinalizerHandler.INVALID_TYPE_ERROR_FINALIZER, new List<String>{ MY_CLASS }),
 			myException.getMessage(),
 			EXCEPTION_SHOULD_HAVE_CORRECT_MESSAGE
 		);
@@ -307,4 +295,4 @@ private with sharing class FinalizerHandlerTest {
 			Database.setSavepoint();
 		}
 	}
-}
+}

trigger-actions-framework/main/default/classes/FlowChangeEventHeader.cls

@@ -113,4 +113,4 @@ public with sharing class FlowChangeEventHeader {
 	public Integer hashCode() {
 		return JSON.serialize(this).hashCode();
 	}
-}
+}

trigger-actions-framework/main/default/classes/FlowChangeEventHeaderTest.cls

@@ -23,10 +23,7 @@ private with sharing class FlowChangeEventHeaderTest {
 
 	@IsTest
 	private static void shouldBeAbleToConstruct() {
-		System.Assert.isNotNull(
-			header,
-			'Unable to construct a FlowChangeEventHeader'
-		);
+		System.Assert.isNotNull(header, 'Unable to construct a FlowChangeEventHeader');
 	}
 
 	@IsTest
@@ -36,9 +33,7 @@ private with sharing class FlowChangeEventHeaderTest {
 
 	@IsTest
 	private static void shouldBeAbleToCompare() {
-		FlowChangeEventHeader other = new FlowChangeEventHeader(
-			new EventBus.ChangeEventHeader()
-		);
+		FlowChangeEventHeader other = new FlowChangeEventHeader(new EventBus.ChangeEventHeader());
 		other.changeType = 'CREATE';
 
 		System.Assert.areEqual(
@@ -57,4 +52,4 @@ private with sharing class FlowChangeEventHeaderTest {
 			'Unable to detect difference between FlowChangeEventHeader and null'
 		);
 	}
-}
+}