-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mediapipe hand #381
base: dev
Are you sure you want to change the base?
Mediapipe hand #381
Conversation
package.json
Outdated
@@ -33,5 +33,8 @@ | |||
"ts-node": { | |||
"typescript": "$typescript" | |||
} | |||
}, | |||
"dependencies": { | |||
"@mediapipe/tasks-vision": "^0.1.0-alpha-12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mayarajan3 -- one note, when you install packages for an extension, you should make sure to run pnpm add
at that extension's location, so each extension can effectively have it's own version of that package. Leads to some duplication in bundle size for sure, but makes our lives of supporting extensions a lot easier (that each extension has it's own, independent dependencies)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change this in an upcoming commit (as I try to diagnose some of the build errors we're having)
@@ -11,6 +11,7 @@ | |||
"author": "", | |||
"license": "ISC", | |||
"dependencies": { | |||
"@mediapipe/tasks-vision": "^0.1.0-alpha-12", | |||
"@tensorflow-models/handpose": "^0.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: can remove
No description provided.