drawer topic carousels should not be filtered on just courses (#1984)

* drawer topic carousels should not be filtered on just courses * rename argument
mitodl · Jan 24, 2025 · 117af25 · 117af25
1 parent 63c0b7b
commit 117af25
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/frontends/main/src/app-pages/DashboardPage/DashboardPage.tsx b/frontends/main/src/app-pages/DashboardPage/DashboardPage.tsx
@@ -43,6 +43,7 @@ import UserListDetailsTab from "./UserListDetailsTab"
 import { SettingsPage } from "./SettingsPage"
 import { DASHBOARD_HOME, MY_LISTS, PROFILE, SETTINGS } from "@/common/urls"
 import dynamic from "next/dynamic"
+import { ResourceTypeEnum } from "api"
 
 const LearningResourceDrawer = dynamic(
   () =>
@@ -451,7 +452,9 @@ const DashboardPage: React.FC = () => {
                           titleComponent="h2"
                           title={`Popular courses in ${topic}`}
                           isLoading={isLoadingProfile}
-                          config={TopicCarouselConfig(topic)}
+                          config={TopicCarouselConfig(topic, [
+                            ResourceTypeEnum.Course,
+                          ])}
                           data-testid={`topic-carousel-${topic}`}
                         />
                       ))}

diff --git a/frontends/main/src/common/carousels.ts b/frontends/main/src/common/carousels.ts
@@ -1,5 +1,11 @@
-import type { ResourceCarouselProps } from "@/page-components/ResourceCarousel/ResourceCarousel"
-import { LearningResourcesSearchRetrieveDeliveryEnum } from "api"
+import type {
+  ResourceCarouselProps,
+  TabConfig,
+} from "@/page-components/ResourceCarousel/ResourceCarousel"
+import {
+  LearningResourcesSearchRetrieveDeliveryEnum,
+  LearningResourcesSearchRetrieveResourceTypeEnum,
+} from "api"
 import { Profile } from "api/v0"
 
 type TopPicksCarouselConfigProps = (
@@ -38,26 +44,29 @@ const TopPicksCarouselConfig: TopPicksCarouselConfigProps = (
 
 type TopicCarouselConfigProps = (
   topic: string | undefined,
+  resourceTypes?: LearningResourcesSearchRetrieveResourceTypeEnum[] | undefined,
 ) => ResourceCarouselProps["config"]
 
 const TopicCarouselConfig: TopicCarouselConfigProps = (
   topic: string | undefined,
+  resourceTypes?: LearningResourcesSearchRetrieveResourceTypeEnum[] | undefined,
 ) => {
-  return [
+  const config: TabConfig[] = [
     {
       label: "All",
       cardProps: { size: "small" },
       data: {
         type: "lr_search",
         params: {
-          resource_type: ["course"],
+          resource_type: resourceTypes || [],
           limit: 12,
           topic: [topic || ""],
           sortby: "-views",
         },
       },
     },
   ]
+  return config
 }
 
 const CERTIFICATE_COURSES_CAROUSEL: ResourceCarouselProps["config"] = [