Fix SCIM API error on patch with nested attributes (#1952)

* Fixed SCIM API for nested profile attributes

* Fix the bug

profiles/scim/adapters.py

@@ -181,13 +181,30 @@ def handle_add(
             self.obj.profile.scim_external_id = value
             self.obj.save()
 
+    def parse_scim_for_keycloak_payload(self, payload: str) -> dict:
+        """
+        Parse the payload sent from scim-for-keycloak and normalize it
+        """
+        result = {}
+
+        for key, value in json.loads(payload).items():
+            if key == "schema":
+                continue
+
+            if isinstance(value, dict):
+                for nested_key, nested_value in value.items():
+                    result[f"{key}.{nested_key}"] = nested_value
+            else:
+                result[key] = value
+
+        return result
+
     def parse_path_and_values(
         self, path: Optional[str], value: Union[str, list, dict]
     ) -> list:
         if not path and isinstance(value, str):
             # scim-for-keycloak sends this as a noncompliant JSON-encoded string
-            value = json.loads(value)
-            value.pop("schema", None)  # part of the spec, not a user prop
+            value = self.parse_scim_for_keycloak_payload(value)
 
         return super().parse_path_and_values(path, value)
 

profiles/scim/views_test.py

@@ -92,6 +92,10 @@ def test_scim_post_user(staff_client):
                                 "schemas": [constants.SchemaURI.USER],
                                 "emailOptIn": 1,
                                 "fullName": "Billy Bob",
+                                "name": {
+                                    "givenName": "Billy",
+                                    "familyName": "Bob",
+                                },
                             }
                         ),
                     }
@@ -107,7 +111,7 @@ def test_scim_post_user(staff_client):
     assert user is not None
     assert user.email == "[email protected]"
     assert user.username == "jsmith"
-    assert user.first_name == "Jimmy"
-    assert user.last_name == "Smith"
+    assert user.first_name == "Billy"
+    assert user.last_name == "Bob"
     assert user.profile.name == "Billy Bob"
     assert user.profile.email_optin is True